Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sign jpackageapplauncher for jdk16+ #158

Merged
merged 1 commit into from
Jun 3, 2021
Merged

sign jpackageapplauncher for jdk16+ #158

merged 1 commit into from
Jun 3, 2021

Conversation

gdams
Copy link
Member

@gdams gdams commented Jun 3, 2021 •
edited
Loading

Fixes the following notarization issue:

temurin-16.jdk/Contents/Home/jmods/jdk.jpackage.jmod/classes/jdk/jpackage/internal/resources/jpackageapplauncher",\n "message": "The binary is not signed.",\n

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@gdams
Copy link
Member Author

gdams commented Jun 3, 2021

run tests

@eclipse-temurin-bot
Copy link
Collaborator

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

@gdams gdams merged commit c3aa08a into adoptium:master Jun 3, 2021
@gdams gdams deleted the jmod branch June 3, 2021 10:12
@karianna karianna added this to the June 2021 milestone Jun 6, 2021
@gdams gdams mentioned this pull request Oct 20, 2021
Open
llxia pushed a commit to llxia/ci-jenkins-pipelines that referenced this pull request Jun 1, 2023
@AdamBrousseau
Merge pull request adoptium#158 from llxia/test2
bb46577 
Set LIGHT_WEIGHT_CHECKOUT to true
@gdams gdams mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@tellison tellison tellison approved these changes

Assignees
No one assigned
Labels
jenkins-pipeline
Projects
None yet
Milestone
June 2021
Development

Successfully merging this pull request may close these issues.
5 participants
@gdams @eclipse-temurin-bot @tellison @andrew-m-leonard @karianna